Open xentek opened 9 years ago
Pull up for this issue https://github.com/styleseek/hyperdrive/pull/33
Can this be closed now that pull request #33 has been merged?
Not sure if this has been tested at an integration level against the original problem that prompted this change, copying and pasting strings from weird sources like Office Documents. Probably want to do that before closing it.
Yeah, it seemed to address some things but not all. Merging in the branch did fix another bug that was in that version, but some of the copy+pasting stuff is still outstanding. Thanks @jpark3000
When strings are copy+pasted from weird sources like Office Documents, the string encoding will sometimes be ASCII-8BIT and causes 500 errors when endpoints try to process them. We should be able to fix this by converting values of params to UTF-8 strings in a new rack middleware that runs early in the chain (e.g. right after we remove non-whitelisted params)