xeokit / xeokit-convert

Convert various AEC model formats for efficient viewing in the browser with xeokit.
https://xeokit.github.io/xeokit-convert/docs/
Other
49 stars 52 forks source link

bug in newest beta: configs.sourceConfigs ||= {}; #128

Open cT4001 opened 7 months ago

cT4001 commented 7 months ago

image

xeolabs commented 7 months ago

Looks fine to me, that's a valid JavaScript expression. What error condition are you experiencing?

cT4001 commented 7 months ago

image

xeolabs commented 7 months ago

What are you doing to get this error?

convert2xkt.js has no problem with this statement when executed via NodeJS, eg.

node convert2xkt.js -s Duplex.gltf -o test.xkt -l

[convert2xkt] Running convert2xkt v1.1.15-beta-1...
[convert2xkt] Using configs in ./convert2xkt.conf.js
[convert2xkt] Converting single input file Duplex.gltf...
[convert2xkt] Reading input file: /Duplex.gltf
[convert2xkt] Input file size: 1433.53 kB
[convert2xkt] Using parser: parseGLTFJSONIntoXKTModel
[convert2xkt] Parsing normals: disabled
[convert2xkt] Input file parsed OK. Building XKT document...
[convert2xkt] XKT document built OK. Writing to XKT file...
[convert2xkt] Converted to: XKT v10
[convert2xkt] Exclude types: 
[convert2xkt] XKT size: 96.46 kB
[convert2xkt] XKT textures size: 0.01kB
[convert2xkt] Compression ratio: 14.86
[convert2xkt] Conversion time: 0.36 s
[convert2xkt] Converted metaobjects: 0
[convert2xkt] Converted property sets: 0
[convert2xkt] Converted drawable objects: 291
[convert2xkt] Converted geometries: 252
[convert2xkt] Converted textures: 0
[convert2xkt] Converted textureSets: 0
[convert2xkt] Converted triangles: 15874
[convert2xkt] Converted vertices: 25262
[convert2xkt] Converted UVs: 0
[convert2xkt] Converted normals: 0
[convert2xkt] minTileSize: 200
[convert2xkt] Writing XKT file: test.xkt
[convert2xkt] Done.
cT4001 commented 7 months ago

I additionally use the -m option to read the metadata json from creoox

node convert2xkt.js -s Duplex.gltf -o test.xkt -m Duplex.json

Anyway, I switched back to latest NON beta currently

cT4001 commented 7 months ago

ah sorry, I saw the exception in my setup comes already when I check the version (and not in the convert itself)

node convert2xkt.js -v