Small bug in destructor of Input.js

xeokit / xeokit-sdk

Open source JavaScript SDK for viewing high-detail, full-precision 3D BIM and AEC models in the Web browser.

https://xeokit.io

Other

738 stars 291 forks source link

Closed tmarti closed 5 years ago

tmarti commented 5 years ago

In those lines of code belonging to src/viewer/scene/Input.js destructor...

... shouldn't it be...

window.removeEventListener("deviceorientation", this._deviceOrientListener);

... instead of...

window.addEventListener("deviceorientation", this._deviceOrientListener);

... as this is the object destructor?

xeolabs commented 5 years ago

Oh yes that's a bug. Could you make a PR?

tmarti commented 5 years ago

Sure! Just wait for next week

xeolabs commented 5 years ago