xeokit / xeokit-sdk

Open source JavaScript SDK for viewing high-detail, full-precision 3D BIM and AEC models in the Web browser.
https://xeokit.io
Other
694 stars 279 forks source link

[FIX] Fix decompression of properties in split metadata files #1543

Closed xeolabs closed 1 week ago

xeolabs commented 1 week ago

This fixes the error where properties values are sometimes undefined when loading metadata from multiple JSONs created by ifc2gltf and convert2xkt in split-model mode.

In this mode, when creating a set of split XKT and JSON metadata files, the properties are often distributed across multiple JSON metadata files.

This can result in property sets in one JSON referencing properties that are defined in a different JSON. Since the references are only resolved locally within each JSON, they can therefore be broken.

This PR fixes this situation by resolving all references between property sets and properties in a batch, once all metadata JSONs have been loaded for a model.