search

xeokit / xeokit-sdk

Open source JavaScript SDK for viewing high-detail, full-precision 3D BIM and AEC models in the Web browser.
https://xeokit.io
Other
738 stars 291 forks source link

Fix broken emphasis fill effect #394

Closed barnabasmolnar closed 4 years ago

barnabasmolnar commented 4 years ago

Hello there,

I've noticed some issues with rendering when picking elements.

This is what I get on my Macbook Pro 13":

mac

And this is what I get on my PC:

pc

FYI:

Same result across all major modern browsers so that doesn't seem to make a difference.

The Mac is an older model (2017 I believe) and has some shitty integrated GPU I'm guessing.

I have a GTX 1070 8GB in my PC. For what it's worth @tothatt81 has a significantly lower powered GPU (GT 1030 2GB) and it works fine for him as well.

The expected result would be what you can see on the PC screenshot.

Could you please look into it? Thank you.

xeolabs commented 4 years ago

Hi, any errors or warnings in the JS console?

barnabasmolnar commented 4 years ago

Yep:

[.WebGL-0x7f8d29062e00]GL ERROR :GL_INVALID_OPERATION : glDrawElementsInstancedANGLE: attempt to access out of range vertices in attribute 5

xeolabs commented 4 years ago

Fixed in @xeokit/xeokit-sdk 1.3.7