xeokit / xeokit-sdk

Open source JavaScript SDK for viewing high-detail, full-precision 3D BIM and AEC models in the Web browser.
https://xeokit.io
Other
728 stars 287 forks source link

Fix size of SectionPlane editing control #480

Closed Amoki closed 3 years ago

Amoki commented 3 years ago

Describe the bug Section plane controls are huge: Capture d’écran de 2020-11-24 16-35-26

And sometimes even bigger: Capture d’écran de 2020-11-24 16-40-24

I updated to 1.5.13, the problem persists (with and without xkt v6).

To Reproduce Open our demo model (MarcAntoinePetit.ifc) Create a section on an axis

sectionPlanesPlugin.createSectionPlane({
  dir: camera.worldRight.map(val => -val),
  pos: math.getAABB3Center(scene.getAABB())
});

Expected behavior The best behavior may be a constant size of section controls, regardless of zoom. Just not huge controls are very OK.

Desktop (please complete the following information): Tried on Linux, latest Firefox and Chromium.

Amoki commented 3 years ago

@xeolabs Do you have any clue? It breaks our section tool :/

xeolabs commented 3 years ago

@Amoki currently the tool sizes itself to the entire model boundary. I'll fix in the next version by sizing it to the view frustum, or something like that.

Amoki commented 3 years ago

Just did a bisect: it works in 1.4.7, it's way too big since 1.4.8 (the merge of RTC-coords).

A fix to just bring back the old size is enough for us if doing a dynamic size is hard.

Amoki commented 3 years ago

Hi @xeolabs, It's been 6 weeks since this bug is here, do you have any info about this?

xeolabs commented 3 years ago

@Amoki it's on the list for this week's release