xeokit / xeokit-sdk

Open source JavaScript SDK for viewing high-detail, full-precision 3D BIM and AEC models in the Web browser.
https://xeokit.io
Other
715 stars 286 forks source link

Fix sticky CameraControl rotation after dragging with combined left & right mouse buttons #623

Closed vadimt2 closed 3 years ago

vadimt2 commented 3 years ago

When you click right & left-click the model is turning around with the mouse even if you don't press on the mouse

https://xeokit.github.io/xeokit-sdk/examples/#BIMOffline_XKT_WaterLock

xeolabs commented 3 years ago

I can't reproduce this - what OS/Browser does this happen iin?

Amoki commented 3 years ago

I can with Firefox and Chromium

xeolabs commented 3 years ago

Are there any special steps to follow?

Opening that page and following those instructions works fine for me on FF and Chrome.

vadimt2 commented 3 years ago

Chrome

vadimt2 commented 3 years ago

Press both right and left click at the same time

Amoki commented 3 years ago

Open the page, press left, press right, release left, release right, move the mouse

Amoki commented 3 years ago

The fix partially broke the pan. If we press shift before the left click, the pan doesn't work. If we press the left button before pressing shift, the pan works.

xeolabs commented 3 years ago

Should be fixed now.