search

xeokit / xeokit-xkt-utils

Deprecated JavaScript tools to generate .XKT files; replaced by https://github.com/xeokit/xeokit-convert
Other
10 stars 9 forks source link

Instanced objects missing in XKT 6 #4

Closed Francois-Thierry closed 3 years ago

Francois-Thierry commented 3 years ago

Hello Lindsay, I hope you are doing well. I'm super hyped by the new version of the XKT, amazing work ! However I noticed what seems to be a regression..

Describe the bug When trying the new XKT version I noticed that there were some missing elements, both on "jittering" and "correct" version of our demo model.

To Reproduce Steps to reproduce the behavior:

  1. Convert a GLTF model to the latest XKT version
  2. Display in xeokit

Expected behavior You can see on the screenshots below that a lot of windows grids and frames are missing.

Screenshots Before image After image

Additional context Why I think it is more of a regression than a bug is that the model looks correct in your twitter post : https://twitter.com/xeolabs/status/1322179784231866370 but not in the corresponding blog post : http://xeokit.io/blog_full_precision_geometry.html nor in the example.

Thanks in advance for the correction, the full precision emulation is a great feature that will alleviate a lot of troubles for us, especially for the multi-models visualization.

xeolabs commented 3 years ago

Hi @Francois-Thierry thanks - I see the bug, will fix!

xeolabs commented 3 years ago

All fixed @Francois-Thierry , thanks for catching that.

The fix is in xeokit-xkt-utils, which is used in xeokit-gltf-to-xkt.

So, to use this fix, update xeokit-gltf-to-xkt to 0.0.6.

xeolabs commented 3 years ago

To test, I re-converted the MAP glTF file to XKT6, and replaced that model in the xeokit-sdk collection. Run that here: https://xeokit.github.io/xeokit-sdk/examples/loading_XKT_jitter_fullPrecision_MAP.html

Francois-Thierry commented 3 years ago

It is fixed, thanks a bunch for the swift correction !