xeolabs / scenejs

An extensible WebGL-based 3D engine. This is an archived project.
https://xeolabs.github.io/scenejs/
Other
649 stars 165 forks source link

camera plugins don't work any longer - due to removed batch update feature #444

Closed KlausBlass closed 8 years ago

KlausBlass commented 8 years ago

As of today, Feb, 21st 2016, my applications stopped working due to camera nodes still using batch update. On SceneJS.org the plugin links point to old code containing, e.g. lookat.set({ eye: { x: eye.x, y: eye.y, z: -zoom }, look: { x: look.x, y: look.y, z: look.z }, up: { x: 0, y: 1, z: 0 } });

Where do I find the new plugins version ?

Thanks, Klaus

xeolabs commented 8 years ago

Hi Klaus, I'd forgotten to update the plugins but Jacqueline caught that and fixed them yesterday. I'll merge her fixes tomorrow - just use the old src for now if you can, should work. On 21 Feb 2016 12:46, "Klaus Blass" notifications@github.com wrote:

As of today, Feb, 21st 2016, my applications stopped working due to camera nodes still using batch update. On SceneJS.org the plugin links point to old code containing, e.g. lookat.set({ eye: { x: eye.x, y: eye.y, z: -zoom }, look: { x: look.x, y: look.y, z: look.z }, up: { x: 0, y: 1, z: 0 } });

Where do I find the new plugins version ?

Thanks, Klaus

— Reply to this email directly or view it on GitHub https://github.com/xeolabs/scenejs/issues/444.

KlausBlass commented 8 years ago

Ah, good, no hurry. BTW the bottom paragraph on SceneJS.org shows a plugins link which still points to version 3.1 ...

xeolabs commented 8 years ago

All merged now Klaus, plugins link fixed, cheers

KlausBlass commented 8 years ago

Really? api/latest/ shows plugins still as 3 months for the last commit. Where did you merge the modified plugins?

tsherif commented 8 years ago

@KlausBlass you can run grunt snapshot to copy the latest plugins into the api/latest directory.

xeolabs commented 8 years ago

I've just run that - snapshot libs and plugins are now built in master and gh-pages,

KlausBlass commented 8 years ago

Perfect. Thanks!