search

xeolabs / scenejs

An extensible WebGL-based 3D engine. This is an archived project.
https://xeolabs.github.io/scenejs/
Other
649 stars 165 forks source link

Basic Picking example reversed names #84

Closed tthmok closed 13 years ago

tthmok commented 13 years ago

http://scenejs.org/dist/curr/extr/examples/basic-picking/index.html

The names for left-right blue and green spheres look to be swapped.

I think the camera eye Z used to be negative which would make sense for the names.

xeolabs commented 13 years ago

Doh - that's right, I fixed up the coordinate system to bring it in line with the OpenGL standard.

I'll fix - and mention this change in the release notes!

Thanks for catching it.

On Sat, May 14, 2011 at 12:57 AM, tthmok reply@reply.github.com wrote:

http://scenejs.org/dist/curr/extr/examples/basic-picking/index.html

The names for left-right blue and green spheres look to be swapped.

I think the camera eye Z used to be negative which would make sense for the names.

Reply to this email directly or view it on GitHub: https://github.com/xeolabs/scenejs/issues/84

xeolabs commented 13 years ago

That is, I fixed the camera position in the examples to bring in line with OpenGL, and fixed the directions of geometry normal vectors. I confuse myself sometimes.

On Sat, May 14, 2011 at 1:00 AM, Lindsay Kay lindsay.kay@xeolabs.com wrote:

Doh - that's right, I fixed up the coordinate system to bring it in line with the OpenGL standard.

I'll fix - and mention this change in the release notes!

Thanks for catching it.

On Sat, May 14, 2011 at 12:57 AM, tthmok reply@reply.github.com wrote:

http://scenejs.org/dist/curr/extr/examples/basic-picking/index.html

The names for left-right blue and green spheres look to be swapped.

I think the camera eye Z used to be negative which would make sense for the names.

Reply to this email directly or view it on GitHub: https://github.com/xeolabs/scenejs/issues/84