search

xeolabs / xeogl

A WebGL-based 3D engine for technical visualization. Not actively maintained.
http://xeogl.org
Other
1.15k stars 264 forks source link

Reflect.getJSON fails when _src is null #169

Closed bradwerth closed 7 years ago

bradwerth commented 7 years ago
Description of the problem

_getJSON calls this._src.slice() without first ensuring that this._src is non-null.

xeogl version
Browser
OS
Hardware Requirements
xeolabs commented 7 years ago

I just removed the Reflect component, which fixes this problem - replaced with CubeTexture, which you can set as a light map or reflection map on xeogl.Lights components - see this example: http://xeogl.org/examples/#materials_metallic_metallicVsRoughness