Cannot set property 'Class' of undefined

xeolabs / xeogl

A WebGL-based 3D engine for technical visualization. Not actively maintained.

http://xeogl.org

Other

1.14k stars 264 forks source link

Cannot set property 'Class' of undefined #195

Open axmand opened 7 years ago

axmand commented 7 years ago

Description of the problem

   // Create a new Class that inherits from this class
    Class.extend = function (prop) {

reports error 'Cannot set property 'Class' of undefined' . Perhaps converts 'Class' by useing babel can resolve this problem?

xeogl version

[ ] Dev
[x] Master
[ ] ...

Browser

[ ] All of them
[ ] Chrome
[ ] Firefox
[ ] Internet Explorer
[x] nodejs

OS

[ ] All of them
[x] Windows
[ ] Linux
[ ] Android
[ ] IOS

Hardware Requirements

xeolabs commented 7 years ago

Oooh yes I know. Prevents xeogl from being used with Browserify as well. I will be looking at this, but possibly not for a few weeks. If you're able to fix this in a pull request, we'd be super grateful ;)

fuzhenn commented 7 years ago

Hi, @xeolabs Would you consider to upgrade xeogl classes to ES6 class? Then we could use tools like babel / rollup to produce consumable distributions for AMD/UMD/Commonjs and ES6 bundlers.