search

xeolabs / xeogl

A WebGL-based 3D engine for technical visualization. Not actively maintained.
http://xeogl.org
Other
1.14k stars 264 forks source link

fix documentation for using own canvas id #229

Closed rubydesign closed 6 years ago

rubydesign commented 6 years ago

Code uses "canvas" not "canvasId" to find user supplied canvas.

rubydesign commented 6 years ago

I would suggest that xeogl always creates the canvas element, but that the user can provide the wrapper for it. Just because that is what he/she most likely wants to style. I could also document the overlay and background that are always created and the fact that the canvas has to be in a parent to whom the overlay and background are added.

rubydesign commented 6 years ago

I hope the addition is ok. This took me 2 hours to find out myself, i hope that it can help someone else.