search

xeolabs / xeogl

A WebGL-based 3D engine for technical visualization. Not actively maintained.
http://xeogl.org
Other
1.15k stars 264 forks source link

Model remove #239

Closed rubydesign closed 6 years ago

rubydesign commented 6 years ago
Description of the problem

The docs of Model talk about adding and removing, but there is no remove. Whenever i touch _remove / removeAll / delete or destroy, i get WebGl warnings about buffers being used that don't belong to the program.

My guess is the rewrite was not quite finished in that area ? I couldn't see any examples either. If you want i can knock a minimal failure together.

Currently i set visibility of all entities in the Model to false. which works :-)

xeogl version
Browser
OS
Hardware Requirements
xeolabs commented 6 years ago

True, I forgot to add remove()!

Fixed - https://github.com/xeolabs/xeogl/commit/287c09c112d4659def872933e768f3e6a41ddc51