search

xeolabs / xeogl

A WebGL-based 3D engine for technical visualization. Not actively maintained.
http://xeogl.org
Other
1.15k stars 264 forks source link

Fixed buildEdgesIndices on large meshes. #275

Closed Artur-Sampaio closed 5 years ago

Artur-Sampaio commented 5 years ago

The check for large indices was being done under the wrong indices, so it was possible for

ia <= 65535 while edgeIndices[indicesReverseLookup[ia]] > 65535.

This caused Uint16Array to not be able to represent the desired edgeIndices (due to the two byte limitation) and for the edges to show incorrectly.

Fixes #274

xeolabs commented 5 years ago

Thanks @Artur-Sampaio !