I find a bug in canvas2image.js

xeolabs / xeogl

A WebGL-based 3D engine for technical visualization. Not actively maintained.

http://xeogl.org

Other

1.15k stars 264 forks source link

I find a bug in canvas2image.js #295

Open jacklincao opened 5 years ago

jacklincao commented 5 years ago

When I use scene.canvas.getSnapshot, The img's height is incorrect, and I find line 154 have 2 iwidth in canvas2image.js, It's should be oSaveCtx.drawImage(oCanvas, 0, 0, oCanvas.width, oCanvas.height, 0, 0, iWidth, iHeight);

xeolabs commented 5 years ago

Thanks! If you like, please make a PR and then I'll merge. This bug has actually been affecting users, so it's great that you found this.

jacklincao commented 5 years ago

ok, I will make a PR soon.