No error when .mtl library not found when loading .obj

xeolabs / xeogl

A WebGL-based 3D engine for technical visualization. Not actively maintained.

http://xeogl.org

Other

1.14k stars 264 forks source link

No error when .mtl library not found when loading .obj #320

Closed arthur-parmentier closed 4 years ago

arthur-parmentier commented 4 years ago

Describe the bug When loading .obj files without attached .mtl files (for instance that specifies only "usemtl"), no error is thrown whereas the file is not loading in the viewere

To Reproduce Replace examples .obj files with any .obj file that specify "usemtl" instead of being associated with a .mtl file and test the examples.

Expected behavior Error should be thrown such as "no mtl found)

mhoelzner commented 4 years ago

i provided a fix for that https://github.com/xeolabs/xeogl/pull/324

xeolabs commented 4 years ago

Merged - thanks Arthur!