xeqi / kerodon

interaction and testing library for html based ring apps.
305 stars 22 forks source link

Allow use of :button for `press' #24

Closed Frozenlock closed 10 years ago

Frozenlock commented 10 years ago

I usually use a button instead of a simple input element to submit my forms. (It can be customized more easily and acts the same way.)

glenjamin commented 10 years ago

The change seems sensible, but would you be able to add a test case for this scenario as well?

strika commented 10 years ago

Fixes #23.

philandstuff commented 10 years ago

:+1: we would like the ability to press buttons too. The asked-for test has been added so is there anything else we can do to help move this along?

glenjamin commented 10 years ago

Whoops, I guess I missed the update on this.

Will aim to review/merge shortly

philandstuff commented 10 years ago

@glenjamin great, thanks! much appreciated :whale: