search

xeqi / kerodon

interaction and testing library for html based ring apps.
304 stars 22 forks source link

Make the default form method GET #25

Closed philandstuff closed 10 years ago

philandstuff commented 10 years ago

The default method for forms is GET, not POST 1. This changes kerodon's behaviour to GET rather than POST when a form element doesn't specify a method attribute.

glenjamin commented 10 years ago

Seems like a sensible change, will have to be in a major version bump as it breaks back-compat.

philandstuff commented 10 years ago

will have to be in a major version bump as it breaks back-compat.

If you're talking about semver, then point 4 of semver is:

Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

which suggests the next version can be whatever number you like.

If this isn't a semver project, then disregard me :smile:

glenjamin commented 10 years ago

You are correct, by major I mean pre-1.0 minor, ie.0.4.0