search

xerial / larray

Large off-heap arrays and mmap files for Scala and Java
Apache License 2.0
400 stars 43 forks source link

Fixed view method of MMapBuffer to use correct address ranges #47

Closed antumbde closed 8 years ago

antumbde commented 8 years ago

MMapBuffer maps the buffer from pageOffset position. MMapBuffer.view needs to adjust the offset to account for pageOffset.

xerial commented 8 years ago

Thanks for the fix!

xerial commented 8 years ago

But it causes JVM crash in jdk7 build. Could you check this? thanks.

antumbde commented 8 years ago

This bug also impacts WrappedLBuffer. New commit fixes that. 'sbt compile' and 'sbt test' ('sbt ~test' ) passed on my machine. I'll track what github CI status

antumbde commented 8 years ago

It passes on oracle-jdk7 but failed on openjdk-7. On first glance, this looks like a platform issue. I'm continuing to double check this. sing /home/travis/.sbt/0.13.0 as sbt dir, -sbt-dir to override. * buffer overflow detected *: java terminated ======= Backtrace: ========= /lib/x86_64-linux-gnu/libc.so.6(__fortify_fail+0x37)[0x7f1a5291ee57] /lib/x86_64-linux-gnu/libc.so.6(+0x108d50)[0x7f1a5291dd50] /usr/lib/jvm/java-7-openjdk-amd64/jre/lib/amd64/libnet.so(Java_java_net_Inet4AddressImpl_getLocalHostName+0x190)[0x7f1a3aba29a0] [0x7f1a489f0d98]

antumbde commented 8 years ago

The build failure with openjdk7 seems to be this issue - https://github.com/travis-ci/travis-ci/issues/5227

It's not related to the patch.

xerial commented 8 years ago

OK. Thanks for the confirmation. There is still travis ci build failure. Let me merge this PR first. I'll check travis ci issue later. Thanks!

antumbde commented 8 years ago

Hey, What's the process for getting this "released" ? -Adwait

On Sun, Feb 28, 2016 at 7:35 PM, Taro L. Saito notifications@github.com wrote:

Merged #47 https://github.com/xerial/larray/pull/47.

— Reply to this email directly or view it on GitHub https://github.com/xerial/larray/pull/47#event-570381810.

xerial commented 8 years ago

Just released larray 0.3.0 with this fix and Scala 2.11 support.