search

xermicus / revive

Solidity compiler for PolkaVM
Apache License 2.0
16 stars 4 forks source link

Revive nodejs version #26

Closed smiasojed closed 2 weeks ago

smiasojed commented 1 month ago

This PR introduces cross-compilation of revive to WebAssembly (WASM) using Emscripten.

The enhancements made allow the compiler to be executed in a Node.js environment, facilitating broader application and integration possibilities.

smiasojed commented 3 weeks ago

Mostly LGTM!

However I'd like to have a build job on the CI for the emscripten target and at least a very basic test case executed.

A simple test is in the second PR. I think we could add the compilation with emscripten target to this PR. WDYT?

xermicus commented 3 weeks ago

Mostly LGTM! However I'd like to have a build job on the CI for the emscripten target and at least a very basic test case executed.

A simple test is in the second PR. I think we could add the compilation with emscripten target to this PR. WDYT?

Fine with me to add any tests later but I'd appreciate a basic CI job ensuring that at least the build process of the compiler itself works with this PR :)

xermicus commented 3 weeks ago

Are the emscripten LLVM build artifacts to be found anywhere? If not we should release them on our own terms, can't justify building them with each run.