search

xermicus / revive

Solidity compiler for PolkaVM
Apache License 2.0
16 stars 4 forks source link

feat: use PolkaVM disassembler #6

Closed 0xf333 closed 4 months ago

0xf333 commented 4 months ago

Desciption

Usage example

zksolc contract.sol --asm --output-dir './tmpdir'

The assembly .zasm file will be outputed in the tmpdir directory

--asm flag test

make test-cli

Now asm.test working properly

0xf333 commented 4 months ago

@xermicus

0xf333 commented 4 months ago

Thanks!

I think since we now have an assembly text format, fn build_assembly_text should be fixed too

Yes, I actually planned build_assembly_text refactoring to go along with the --zkasm fix, which will be in my next pull request. There seems to be more to it than simply giving it the correct assembly text.

xermicus commented 4 months ago

Thanks! I think since we now have an assembly text format, fn build_assembly_text should be fixed too

Yes, I actually planned build_assembly_text refactoring to go along with the --zkasm fix, which will be in my next pull request. There seems to be more to it than simply giving it the correct assembly text.

Right, so this will remove the redundant parts and just use contract.build everywhere

0xf333 commented 4 months ago

Right, so this will remove the redundant parts and just use contract.build everywhere

Yeah, that's what I'm going for.