search

xeroc / piston-lib

Python Library for Steem
MIT License
40 stars 33 forks source link

Pass prefix to PublicKey() in witness_update() #63

Closed bitphage closed 6 years ago

bitphage commented 7 years ago

This fixes the following error with golos:

Traceback (most recent call last):
  File "./update_witness.py", line 69, in <module>
    main()
  File "./update_witness.py", line 66, in main
    update_witness(golos, pubkey, conf['url'], conf['props'], conf['witness'])
  File "./update_witness.py", line 19, in update_witness
    raise e
  File "./update_witness.py", line 16, in update_witness
    steem_instance.witness_update(signing_key, url, props, account=account)
  File "/home/vvk/devel/golos/golos-witness-tools/venv/lib/python3.4/site-packages/piston/steem.py", line 912, in witness_update
    raise e
  File "/home/vvk/devel/golos/golos-witness-tools/venv/lib/python3.4/site-packages/piston/steem.py", line 910, in witness_update
    PublicKey(signing_key)
  File "/home/vvk/devel/golos/golos-witness-tools/venv/lib/python3.4/site-packages/pistonbase/account.py", line 79, in __init__
    super(PublicKey, self).__init__(pk, prefix)
  File "/home/vvk/devel/golos/golos-witness-tools/venv/lib/python3.4/site-packages/graphenebase/account.py", line 216, in __init__
    self._pk = Base58(pk, prefix=prefix)
  File "/home/vvk/devel/golos/golos-witness-tools/venv/lib/python3.4/site-packages/graphenebase/base58.py", line 60, in __init__
    raise ValueError("Error loading Base58 object")
ValueError: Error loading Base58 object
codecov-io commented 7 years ago

Codecov Report

Merging #63 into develop will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #63   +/-   ##
========================================
  Coverage    53.62%   53.62%           
========================================
  Files           35       35           
  Lines         3021     3021           
========================================
  Hits          1620     1620           
  Misses        1401     1401
Impacted Files Coverage Δ
piston/steem.py 42.15% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19d1755...79caed3. Read the comment docs.