xeroc / python-graphenelib

Python3 library for Graphene-based blockchains
MIT License
74 stars 60 forks source link

Using python-bitshares without writing anything to disk #143

Open RuneStone0 opened 4 years ago

RuneStone0 commented 4 years ago

Background: I'm running python-bitshares on Google AppEngine, which doesn't allow writes to disk, causing exceptions because python-bitshares attempt to write the sqlite database to disk. This happens, even if BitShares() is initialized with keys: bitshares = BitShares(node=mynode, keys=[mykey])

Root Cause: This line: self.config = kwargs.get("config_store", SqliteConfigurationStore(**kwargs)) (reference) is executed when a new BitShares() instance is created, resulting in disk writes.

This happens even if config_store is set while creating a new BitShares() instance like below:

from graphenestorage import InRamConfigurationStore
bitshares = BitShares(node=mynode, keys=[mykey], config_store=InRamConfigurationStore())

I suspect that kwargs.get() is causing this issue. For some reason it will call the default value even if another value is parsed to it (in this case SqliteConfigurationStore()). Once SqliteConfigurationStore() is called a folder will be created on disk (reference)

I'm not sure what the best way to fix this, I went with a quick hack:

bitshares = BitShares(node=node, keys=[app.config["WIF"]], config_store="ram") 

and then patched sqlite.py (adding the first line below):

        if kwargs.get("config_store", None) is None:
            if os.path.isdir(data_dir):  # pragma: no cover
                print("checking folder")
                return
            else:  # pragma: no cover
                print("creating folder")
                os.makedirs(data_dir)
xeroc commented 4 years ago

super helpful, thanks!

RuneStone0 commented 4 years ago

Any ETA on this or can I somehow help with this?

xeroc commented 4 years ago

I was looking for a more general solution, however, the way that @Blockchain.inject works, is that it initialized stuff already. Couldn't find an easy approach just yet, sorry.

In the meantime, you may just install your own patch and work with that.