search

xeruf / monsterutilities

Browse, stream and download Monstercat Songs
GNU General Public License v3.0
31 stars 2 forks source link

Close the output file so it can be renamed as intended. #35

Closed Shinisuryu closed 6 years ago

Shinisuryu commented 6 years ago

Friend suggested I should make a pull request. #34

xeruf commented 6 years ago

Thank you very much!

I am not merging this, because I will solve the issue in another way, but you finally pointed me to the solution of a a very important issue and I really appreciate this :)

Shinisuryu commented 6 years ago

Awesome! That's exactly why I didn't want to at first, but said friend pointed out it could just be closed.

xeruf commented 6 years ago

That friend was right :) opening a PR is almost always a greater help than just opening an issue, even if it doesn't get merged in the end, since it communicates valuable information about the root of the issue.

The bug is now fixed and I'll publish a new version - please do try it and always report any problems you encounter ;)

Shinisuryu commented 6 years ago

Gotcha, still a bit inexperienced with stuff like this. I will though!