search

xeruf / monsterutilities

Browse, stream and download Monstercat Songs
GNU General Public License v3.0
31 stars 2 forks source link

Connection resets bork the downloader #54

Closed C0rn3j closed 5 years ago

C0rn3j commented 5 years ago

01:29:03 Error downloading Matroda - Shut It Down: SocketException: Connection reset

Looks like the downloader doesn't retry on connection reset and will error out and enter a state where the estimated time and finish state is off.

image

EDIT: Actually counter seems to bork even when download finishes normally

image

xeruf commented 5 years ago

Yeah, Connection resets are annoying. I should have fixed the counter in the latest commit though, so this confuses me a bit? Do you have logs for me?

C0rn3j commented 5 years ago

Seems 100% reproducible so far. I just select these 3 songs and download them in FLAC. Nothing interesting in the log however.

18:54:22 [JavaFX Application Thread] INFO   x.m.downloader.TabDownloader   Starting Downloader for 3 Releases with 3 Tracks
18:54:22 [mu-worker-14             ] DEBUG  x.m.downloader.Download        Downloading Project 46 & Gemellini - Deadline to /mnt/3tbRED2/MonsterTest
18:54:22 [mu-worker-28             ] DEBUG  x.m.downloader.Download        Downloading Project 46 - Reasons to /mnt/3tbRED2/MonsterTest
18:54:22 [mu-worker-29             ] DEBUG  x.m.downloader.Download        Downloading Matroda - Shut It Down to /mnt/3tbRED2/MonsterTest
xeruf commented 5 years ago

Hmm weird, I get no errors at all. Might it be related to your internet? Try running the application at loglevel trace (see Readme) and check the log again.

C0rn3j commented 5 years ago

There was no errors downloading these 3 songs, just the broken countdown.

I only got one error related to the conn reset and I think that was an actual network error, I'd just expect the client to perhaps retry a few times with a notice before ultimately failing with an error.

xeruf commented 5 years ago

oh yes, I made a dumb mistake with the counter ^^