Additional setting for maximum APIConnection simultaneous connections

xeruf / monsterutilities

Browse, stream and download Monstercat Songs

GNU General Public License v3.0

31 stars 2 forks source link

Additional setting for maximum APIConnection simultaneous connections #59

Closed defvs closed 5 years ago

defvs commented 5 years ago

This adds a new settings called "Connection speed" that changes the maximum number of simultaneous connections on APIConnection depending on the user's selected speed.

This is what it looks like : Video

Values are subject to be changed; needs testing. 30 is the good number on ADSL I've tested (3 different places with around 8Mb/s = 1MB/s)

Dial-up : 100kb/s = 5 maxConnections
ADSL / 3G : 10Mb/s = 30 maxConnections
Cable / 4G : 100Mb/s = 150 maxConnections
Fiber : 300+Mb/s = 300 maxConnections

defvs commented 5 years ago

As I said the maxConnection needs tweaking. I can't test for anything above ADSL.

xeruf commented 5 years ago

I can test it above that when I'm back home (in about a month lol), my internet is pretty fast. Why are you completely ignoring the processors now though? Especially when there are many simultaneous connections, it also puts quite a bit of load on your pc.

defvs commented 5 years ago

Impact on the processor is not very important imo.

defvs commented 5 years ago

What we could add for the processor thing is a min() with value1 being the maxConnection from the settings, and the other being the processor count * connections thing.

defvs commented 5 years ago

Usage of processor count as well in e9c84dfb27d1efc10098f537abe16423fb143182

defvs commented 5 years ago

Ready to merge I guess. Feel free to point issues before merge.