search

xetus-oss / docker-archiva

A docker image for Apache Archiva
Apache License 2.0
55 stars 34 forks source link

Rebase to Eclipse Temurin docker image. #34

Closed mattmatician closed 2 years ago

mattmatician commented 2 years ago

The openjdk:8-jdk-alpine docker image is 3 years old and is not maintained.

See this notice: https://github.com/docker-library/docs/blob/master/openjdk/README.md#openjdkversion-alpine

and quoting directly:

The OpenJDK port for Alpine is not in a supported release by OpenJDK, since it is not in the mainline code base. It is only available as early access builds of OpenJDK Project Portola. See also https://github.com/docker-library/openjdk/pull/235#issuecomment-424599754. So this image follows what is available from the OpenJDK project's maintainers.

What this means is that Alpine based images are only released for early access release versions of OpenJDK. Once a particular release becomes a "General-Availability" release, the Alpine version is dropped from the "Supported Tags"; they are still available to pull, but will no longer be updated.

I recommended migrating to Eclipse Temurin as they support Alpine and maintain their 8-jdk-alpine equivalent docker tag. See here: https://github.com/docker-library/docs/blob/master/eclipse-temurin/README.md#eclipse-temurinversion-alpine

Eclipse Temurin make no reservations against Alpine, and their docker image is maintained and supported (and was updated 12 days ago at time of writing) and contains the latest update of Java 8u332 (instead of 8u212 provided by openjdk:8-jdk-alpine)

I ran make test and everything passed successfully. The location of the cacerts file has changed with this migration, so the respective references were updated.

tkent commented 2 years ago

👋 @mattmatician - Thanks for the thorough PR and description! Sorry I didn't get a chance to look at it until now.

I agree, moving away from the not-maintained base image is definitely the way to go. I've validated the tests work locally and the image comes up as expected, so I'll move this into the master branch and the v2 editions.