ldflags cannot change value of a constant

xetys / hetzner-kube

A CLI tool for provisioning kubernetes clusters on Hetzner Cloud

Apache License 2.0

745 stars 116 forks source link

Closed kalbasit closed 5 years ago

kalbasit commented 5 years ago

^^ this should be var version = "DEVELOP" instead of a const as it cannot be set via ldflags.

$ make VERSION=1.0.0 build
[ ... ]
$ ./dist/hetzner-kube-1.0.0-linux-amd64 version 
DEVELOP

mavimo commented 5 years ago

@kalbasit nice catch, thx!