search

xetys / hetzner-kube

A CLI tool for provisioning kubernetes clusters on Hetzner Cloud
Apache License 2.0
745 stars 116 forks source link

Fix hcloud controller manager #295

Closed alexzimmer96 closed 5 years ago

alexzimmer96 commented 5 years ago

This should fix issue #294

In the current version, the "hcloud-controller-manager"-addon wants to update the (non-existing) flannel Daemonset. This has been corrected to canal.

It also tries to use version 1.2.0 of the hcloud-cloud-controller-manager which is not suitable for Kubernetes 1.6. I've pushed this version.

And because thats not enough, there is also a bug in the new cloud-controller-manager deployment spec which requires a "network"-key inside the hcloud secret even if it is not used inside the deployment. I added a workaround to remove this secret from the deployment-spec using a patch-request.

Tested this on my cluster

alexzimmer96 commented 5 years ago

@xetys

xetys commented 5 years ago

LGTM