search

xetys / hetzner-kube

A CLI tool for provisioning kubernetes clusters on Hetzner Cloud
Apache License 2.0
745 stars 116 forks source link

Make CNI configurable and add Calico as an option #308

Open MattiasGees opened 4 years ago

MattiasGees commented 4 years ago

This makes CNI configurable so people can start adding other CNI support to it. Calico is also now one of the options to use. The default is still Canal and it will be picked automatically when no option is given.

xetys commented 4 years ago

Do you think you can fix the CC issues, too?

MattiasGees commented 4 years ago

I have been looking at how to optimise it and not sure how to do it. Pointers are welcome :)

validateClusterCreateFlags only adds 3 lines. Even when I move it to another method it will stay the same

InstallMasters adds 5 lines, but I am also not sure it is worth moving that part to another method

MattiasGees commented 4 years ago

@xetys wdyt?

xetys commented 4 years ago

I would say ignore CC, but pls resolve the merge conflicts

MattiasGees commented 4 years ago

Merge conflicts have been resolved.