search

xetys / hetzner-kube

A CLI tool for provisioning kubernetes clusters on Hetzner Cloud
Apache License 2.0
746 stars 116 forks source link

Bump hcloud-cloud-controller-manager version #316

Closed reixd closed 4 years ago

reixd commented 4 years ago

The old v1.5.0 manifest is no longer available, therefore need to change the version to the current release.

mavimo commented 4 years ago

@reixd thanks! The issue that I see is that we are using the master branch, then when master is updated the code will change. Can we refer to the tagged version (eg: https://github.com/hetznercloud/hcloud-cloud-controller-manager/tree/v1.5.0/deploy or https://github.com/hetznercloud/hcloud-cloud-controller-manager/tree/v1.5.1/deploy ) so we are keeping the right reference to the file also if the code on master change? Thx!!

mavimo commented 4 years ago

@reixd thx for the fix!

@xetys LGTM