Migrate to PgnViewerJS v1.4.x

xeyownt commented 3 years ago

Lot of stuff happened to PgnViewerJS since v0.9.6. Let's try to migrate to latest version v1.4.x...

xeyownt commented 3 years ago

First summary of changes:

PgnViewerJS now distributed via npm.
Single minified JS pgnv.js, and a set of asset files.
Path to asset files must be properly configured, through some variable __globalCustomDomain.

xeyownt commented 3 years ago

More changes are necessary to get basic board displayed:

xeyownt commented 3 years ago

No pieces are shown in MW, although there are showing fine in example.html. I could fix this by patching temporarily chessground/render.js (see https://github.com/ornicar/chessground/issues/169).

xeyownt commented 3 years ago

I now have a version that works mostly ok, with some regressions but improvements too:

Improvements:

All themes work the same. They no longer require extra attributes and neither do they get out their div space.
When using goto, the origin and destination squares are now highlighted.

Regressions:

print mode no longer displays intermediate boards (https://github.com/mliebelt/PgnViewerJS/issues/190).
layout left or right seems to be floating, and does float over surrounding text and buttons. Need to fix that in surrounding div probably.
layout left seems to have unnecessary space on the top. See example page (Anserssen, Adolf vs. Dufresne, Jean).
Attribute showNotation does not work anymore. An easy fix probably.
Attribute size does not work as before.
Attribute headers... but not sure what it was doing before.
When we have many board on the same pages, the length of the page is artificially long, even though most of the page is empty. When going in inspector mode, the page length is back to normal.
class=bigger does not work anymore.

Todo:

xeyownt / mwpgnjs