xeyownt / xseticon

xseticon from Paul Evans -- http://www.leonerd.org.uk/
GNU General Public License v2.0
32 stars 11 forks source link

Clarify license, potentially replace Fatal_Error #12

Closed mk-pmb closed 2 years ago

mk-pmb commented 2 years ago

Between the lines // FROM programs/xlsfonts/dsimple.c and // END FROM, we currently have the functions

However, I can only find Fatal_Error in Ubuntu's source of xlsfonts/dsimple.c.

Are the others your own creation? Then we should adjust the END FROM marker.

Even better would be to write our own Fatal_Error function as well, because I can't currently see license compatibility.

Maybe it would suffice to have Fatal_Error be a trivial function that just prints the error message, and a comment for where to find a fancier function (e.g. the Ubuntu link above) if someone wants to make a temporary debug build.

mk-pmb commented 2 years ago

It might even be possible to add a CLI option to dynamically load the fancy Fatal_Error from xlsfonts on systems where the latter is installed.

mk-pmb commented 2 years ago

A fork that entirely omits the section in question is now available.

xeyownt commented 2 years ago

TBH I have no idea of the origin of the license claim since this code is not mine. I just hosted here because I used the tool at some time, and it was nowhere to be found. I mailed the author and never got any reaction.

I doubt however that the claim was for the fatal_error function because this function is too generic (you find these everywhere).

But happy to see the project being forked ;-)