search

xeyownt / xseticon

xseticon from Paul Evans -- http://www.leonerd.org.uk/
GNU General Public License v2.0
34 stars 13 forks source link

Implementation of different image formats #9

Open ahsand97 opened 2 years ago

ahsand97 commented 2 years ago

Hey I think I implemented support to multiple formats using the ImageMagick high level C API, I already tested with .svg, .xpm, .ico, .png, .jpg and extensionless valid image and it works.

Demonstration: Images used:

Screenshot_20211218_214033

extensionless .svg file image

.svg file image

.png file image

.xpm file image

.jpg file (almost invisible but is the twitter one) image

.ico file image

PS: Also I refactored some code solving some warnings that Intellij CLion was suggesting.

xeyownt commented 2 years ago

Hi ahsand97, thanks for the pull request. I'll give it a try and integrate it if ok.

ahsand97 commented 2 years ago

Hi ahsand97, thanks for the pull request. I'll give it a try and integrate it if ok.

Thanks, I didn't update the dependencies to the snap version cuz I didn't reallt know how to, so I believe the snap doesn't have the MagickWand dependency yet