search

xfangfang / Macast

Macast is a cross-platform application which using mpv as DLNA Media Renderer.
https://xfangfang.github.io/Macast/
GNU General Public License v3.0
5.91k stars 373 forks source link

[Bug]The App cannot quit by quit button #89

Closed mikal closed 2 years ago

mikal commented 2 years ago

The app cannot quit by clicking "quit" in the menubar. Here are logs & running environment.

Model: MacbookPro A2141 OS: MacOS 11.5.2 APP：0.6.5 Logs: /Applications/Macast.app/Contents/MacOS/Macast Macast Loading Default Language en_US {'Additional_Interfaces': [], 'ApplicationPort': 1068, 'Blocked_Interfaces': [], 'CheckUpdate': 0, 'DLNA_FriendlyName': 'Macast(xxxxs-MBP.lan)', 'DLNA_Renderer': 'Default', 'MenubarIcon': 1, 'PlayerHW': 1, 'PlayerHW_Force': 1, 'PlayerSize_Auto': 2, 'StartAtLogin': 0, 'USN': 'a0fd2220-7261-4697-9813-622af674b466'} Load renderer MPVRenderer done using renderer: Default 2021-10-28 22:10:01.200 Macast[15272:761302] WARNING: the default quit button is disabled. To exit the application gracefully, another button should have a callback of quit_application or call it indirectly.

Besides, I find Macast has traffic with 239.255.255.250. What are traffic for? Thanks!

xfangfang commented 2 years ago

239.255.255.250 is a local address used for SSDP(Simple Service Discovery Protocol).

From the log, the problem may be that the app exits before mpv player is started, resulting in a deadlock. Can you try to wait a little longer(more than 5s) then exit the app?

I hope this can solve your problem temporarily. I'll fix it later, thanks for your feedback.

mikal commented 2 years ago

Thanks for your great App! The App can quit after stopping cast. If not stop cast, the App would freeze even after 10s.

xfangfang commented 2 years ago

Thanks for the kind words.

Can't reproduce on my computer.

If the application finally closes successfully, maybe is that your computer respond a little slowly? Can you add more log when the app cannot be closed?

or try the latest build of Macast beta version. https://github.com/xfangfang/Macast/actions/runs/1334243905

mikal commented 2 years ago

The application can be exited after being open for more than 10 mins. My OS is just reinstalled and cpu: i9 & ram:32G. I suppose it's not related with hardware performance. Thank you!

Here are the logs. /Applications/Macast.app/Contents/MacOS/Macast Macast Loading Default Language en_US {'Additional_Interfaces': [], 'ApplicationPort': 54012, 'Blocked_Interfaces': [], 'CheckUpdate': 0, 'DLNA_FriendlyName': 'Macast(xxxx-MBP.lan)', 'DLNA_Renderer': 'Default', 'MenubarIcon': 1, 'PlayerHW': 1, 'PlayerHW_Force': 1, 'PlayerSize_Auto': 2, 'StartAtLogin': 0, 'USN': '4f1e5553-cbe0-4c7c-8dfd-78e32e5a15c0'} Load renderer MPVRenderer done using renderer: Default 2021-10-30 11:41:59.831 Macast[3937:489552] WARNING: the default quit button is disabled. To exit the application gracefully, another button should have a callback of quit_application or call it indirectly. INFO:main:service_start ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:cherrypy.error:[30/Oct/2021:11:42:00] ENGINE Started monitor thread 'Autoreloader'. INFO:cherrypy.error:[30/Oct/2021:11:42:00] ENGINE Started monitor thread 'SSDP_NOTIFY_THREAD'. INFO:cherrypy.error:[30/Oct/2021:11:42:00] ENGINE Bus STARTED INFO:main:Server current run on port: 54012 ERROR:MPVRenderer:mpv ipc socket start connect INFO:MPVRenderer:{'event': 'property-change', 'id': 3, 'name': 'pause', 'data': False} INFO:MPVRenderer:{'event': 'property-change', 'id': 1, 'name': 'volume', 'data': 50.0} INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 INFO:main:ssdp_update_ip ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 ERROR:SSDPServer:add membership 192.168.50.124 ERROR:SSDPServer:add membership 192.168.50.220 2021-10-30 11:49:17.262 Macast[3937:489552] <MenuItem: ['Quit' -> []; callback: <bound method MenuItem._rumpsCallback of <macast.gui.MenuItem object at 0x13a7cc910>>]> INFO:cherrypy.error:[30/Oct/2021:11:49:17] ENGINE Bus STOPPING INFO:cherrypy.error:[30/Oct/2021:11:49:18] ENGINE HTTP Server cherrypy._cpwsgi_server.CPWSGIServer(('0.0.0.0', 54012)) shut down INFO:cherrypy.error:[30/Oct/2021:11:49:18] ENGINE Stopped thread 'Autoreloader'. INFO:cherrypy.error:[30/Oct/2021:11:49:18] ENGINE Stopped thread 'SSDP_NOTIFY_THREAD'. INFO:MPVRenderer:stoping mpv and mpv ipc ERROR:MPVRenderer:mpv ipc stopped INFO:MPVRenderer:mpv stopped INFO:main:service_stop ERROR:SSDPServer:drop membership 192.168.50.124 ERROR:SSDPServer:drop membership 192.168.50.220 INFO:cherrypy.error:[30/Oct/2021:11:49:18] ENGINE Bus STOPPED INFO:cherrypy.error:[30/Oct/2021:11:49:18] ENGINE Bus EXITING INFO:cherrypy.error:[30/Oct/2021:11:49:18] ENGINE Bus EXITED INFO:cherrypy.error:[30/Oct/2021:11:49:18] ENGINE Waiting for child threads to terminate... INFO:main:Service stopped 2021-10-30 11:49:18.360 Macast[3937:489552] closing application

xfangfang commented 2 years ago

this log shows:

  1. Macast opened at 11:41:59
  2. At 11:49:17, Quit button was clicked
  3. And Macast closed at 11:49:18

It looks normal. Can you show me the log and screen recording when an error occurs?

xfangfang commented 2 years ago

Is there any update?