xfangfang / borealis

Hardware accelerated, Nintendo Switch inspired UI library for PC, Android, iOS, PSV, PS4 and Nintendo Switch
Apache License 2.0
31 stars 21 forks source link

fix selectcell dismiss callback #26

Closed dragonflylee closed 1 year ago

dragonflylee commented 1 year ago

when brls::Dialog opened in brls::SelectorCell selection event, which in brls::Dropdown::didSelectRowAt, top Activity (dialog) will pop, and dialog will not show https://github.com/xfangfang/borealis/blob/wiliwili/library/lib/views/dropdown.cpp#L147

to solve this problem, add dismissCb fired after dropdown dismiss

this issue introduced by https://github.com/xfangfang/borealis/pull/24

xfangfang commented 1 year ago

现在可以合并了吗?

dragonflylee commented 1 year ago

现在有个问题是,如果 SelectorCell 没有通过 init 方法初始化,dismissCb 会是空指针

xfangfang commented 1 year ago

那感觉还好哈,如果不 init 的话,SelectorCell 也没啥用。


说个题外话:

之前说的硬解,我看到你有提交一些内容了,现在是可以正常用的吗?

我尝试了一下,遇到了相似的问题,貌似我这边的问题是需要把 tx1_device_init 中 /dev/nvhost-nvjpg 相关的内容注释掉才行,不知道你那边现在进展到什么状态了。

dragonflylee commented 1 year ago

硬解部分目前没啥进展,根据 averne 大佬所言 HEVC-10bit 似乎还有问题 https://gbatemp.net/threads/nxmp-nintendo-switch-media-player.601868/page-40#post-10233164

而我的 NAS 里大部分都是这种编码的,所以再等等大佬吧


另外我这边 还有大量 Jellyfin API 没有接入,像是 收藏、下载之类的,所以目前还在做功能补完。

xfangfang commented 1 year ago

了解啦,那我也先等等吧。

先合并这个PR了。