search

xfangfang / borealis

Hardware accelerated, Nintendo Switch inspired UI library for PC, Android, iOS, PSV, PS4 and Nintendo Switch
Apache License 2.0
31 stars 21 forks source link

Editable builtin metric values #59

Closed ThisALV closed 8 months ago

ThisALV commented 8 months ago

This PR allows library user to changes the default metrics for borealis component, for example: the sidebar width

xfangfang commented 8 months ago

Thanks for your contribution, could you do the same to brls::Theme ?

XITRIX commented 8 months ago

Namings now a bit confusing, we have add and set functions and it’s not really obvious what’s the difference, maybe better to allow already existing “add” function to override previous value? Or instead of setMetrics name it updateMetrics

xfangfang commented 8 months ago

Namings now a bit confusing, we have add and set functions and it’s not really obvious what’s the difference, maybe better to allow already existing “add” function to override previous value?

I happened to do what you said, but I haven't pushed it yet. Pushed a new commit instead: https://github.com/xfangfang/borealis/pull/62