xfbs / diff.rs

Web application to render a diff between Rust crate versions. Implemented in Yew, runs fully in the browser as WebAssembly.
https://diff.rs
MIT License
105 stars 11 forks source link

Green "+ X" value barely readable if file is selected #22

Closed SwishSwushPow closed 2 weeks ago

SwishSwushPow commented 3 months ago

Hello everyone!

diff.rs is an essential website for us to review changes whenever we update dependencies and we love it for that, but I've noticed that whenever I select a file the green "+ X" lines indicator becomes basically unreadable. I am using a rather well color-calibrated display whenever I work from home so I think this is not an issue on my side. Maybe it would be possible to switch the colors when a file is selected or choose a different green hue? If I find the time I can try to experiment with this a bit, but for now I've only attached a screenshot of the current situation. I think improving this could also improve the accessibility of the page.

CleanShot 2024-07-04 at 08 30 40@2x

xfbs commented 1 month ago

I'm working on redoing the left navigation component!

xfbs commented 2 weeks ago

I think I'll be able to replace the previous yewprint-based component with a tailwind-based one this weekend. I am horrible at doing web dev stuff, it's a learning curve for me. But hopefully then I can get three things fixed:

xfbs commented 2 weeks ago

This one should be fixed on latest master.