Prettier code folding elements

xfbs / diff.rs

Web application to render a diff between Rust crate versions. Implemented in Yew, runs fully in the browser as WebAssembly.

https://diff.rs

MIT License

105 stars 11 forks source link

Prettier code folding elements #36

Open xfbs opened 1 week ago

xfbs commented 1 week ago

Currently, we have these little boxes for code folding:

Screenshot from 2024-10-13 16-10-36

I think we can make this look prettier. For example, GitHub uses these blue lines to control the folding:

Screenshot from 2024-10-13 16-11-27

They are defined in src/components/diff_view.rs in the DiffLineGroup component, and their style is in static/style.css.

xfbs commented 1 week ago

Idea: can use the iconography of GitHub for this, since they permissively license them: octicons. GitHub has put a lot of thought into creating these icons, they are pretty and coders should be used to them.

xfbs commented 5 days ago

I've just pushed a commit which implements this.

Currently broken:

line numbers for old/new aren't right, needs fixing
want to add a button expand all
github does an incremental unfold.. when you press the button, it reveals the next 15 lines, but not all of them. not sure if we want this too or if we want to keep it simple.