search

xfbs / diff.rs

Web application to render a diff between Rust crate versions. Implemented in Yew, runs fully in the browser as WebAssembly.
https://diff.rs
MIT License
105 stars 11 forks source link

Make the two panes independently scrollable #8

Closed Alphare closed 1 year ago

Alphare commented 1 year ago

This is a small step towards a more ergonomic UI.

xfbs commented 1 year ago

Hey, thanks a lot for working on this!

I tested this out locally and it looks good to me. Putting the styles into a CSS file is definitely a lot cleaner. One thing I saw is that this cuts off the output because the diff view is smaller:

Screenshot from 2023-03-10 21-46-49

Maybe we should make this view take up the remainder of the screen space?

Alphare commented 1 year ago

Ah right. I hadn't looked at this specific resolution because the responsiveness should be reworked in the general case. This is something that can be addressed in a separate PR, maybe I'll do it, but I'm working on implementing #7. For now, we could probably just drop the width directive. Let me send another version soon-ish.

Alphare commented 1 year ago

@xfbs This should fix the specific issue you underlined.

xfbs commented 1 year ago

LGTM, thanks for the quick fix!