import (coda) still required

xfim / ggmcmc

Graphical tools for analyzing Markov Chain Monte Carlo simulations from Bayesian inference

111 stars 31 forks source link

import (coda) still required #30

Closed dmenne closed 11 years ago

dmenne commented 11 years ago

ggs_density as an example still required import of coda when used together with rstan. When coda is imported, traceplot(with implicit) rstan falsely dispatches to coda::traceplot, giving an error. rstan::traceplot works in this case, but is not nice.

ggmcmc github version, installed today.

xfim commented 11 years ago

Solved by #691c7137. Prior to this commit, processing stan samples relied on functions from coda. Now coda it is no more required, at least for stan (either using stanfit or from csv files). Please, test it @dmenne.

dmenne commented 11 years ago

Looks good to me. I know how nasty these dependencies can be, so maybe one day we find another case -.)