search

xfim / ggmcmc

Graphical tools for analyzing Markov Chain Monte Carlo simulations from Bayesian inference
111 stars 31 forks source link

Use the inherits function instead of "==" for the class determination #76

Closed johnaponte closed 2 years ago

johnaponte commented 2 years ago

Hi, I propose a modification to the ggs function to make the comparison of the classes with the inherits instead of the "==" as if the object has more than one class it produces a lot of warnings every time the comparison is made.

xfim commented 2 years ago

Dear @johnaponte ,

Thank you very much for the pull request. I agree, and I should have done that a long time ago.

In the pull request you have also included 3 files that are not needed at all, and that belong to your personal RStudio management. I can manually pass the changes, since they are very few, but in order to properly acknowledge this, I would prefer to accept your PR. Can you therefore please try another PR without the three files (commit d3d2102b987e4fd73736fadd5e2ec86bf0b0724a) and with only the changes in ggs.R in order to keep the repository clean?

Thank you very much.