search

xfiveco / generator-chisel

Chisel is a development framework for creating easy to maintain and fast WordPress websites.
https://www.getchisel.co
MIT License
269 stars 37 forks source link

Port setting #143

Closed davidbwaters closed 7 years ago

davidbwaters commented 7 years ago

Hi, it would be nice to be able to specify a port for when running the generator. Thanks.

thymikee commented 7 years ago

Hi @davidbwaters, thanks for bringing that up.

We're trying to use minimum setup steps possible while generating project just to not frustrate most of our users. And setting up different default port was never an issue, because BrowserSync we use to serve the page handles used ports and adjust this automatically.

You can always override this behaviour in gulp/tasks/serve and add port: XXXX to browserSyncConfig object. I know this may not be ideal for you, but it's possible

davidbwaters commented 7 years ago

Hey, I was referring to setting up the Wordpress port setting for connecting to the DB. Would be nice if the generator had those filled with defaults and you could just confirm through them if needed. As it is now, the install can't progress without the default ports.

thymikee commented 7 years ago

Oh, this makes more sense! Are you willing to send a PR with the feature? 🙂

luboskmetko commented 7 years ago

This is done and will be in the next release.