search

xfiveco / generator-chisel

Chisel is a development framework for creating easy to maintain and fast WordPress websites.
https://www.getchisel.co
MIT License
269 stars 37 forks source link

Resultions for sanitize.css #506

Open marziolek opened 3 years ago

marziolek commented 3 years ago

package.json needs "resolutions": { "sanitize.css": "12.0.1" },

edenizk commented 3 years ago

Hi @luboskmetko,

I have added the sanitize.css to the resolutions you can see in this PR. There is one problem, it will create a problem for ppl who are not using yarn because npm doesn't support "resolutions".
Some solutions I've found is using this package for converting resolutions for npm users https://www.npmjs.com/package/npm-force-resolutions
or using this script from https://newbedev.com/npm-equivalent-of-yarn-resolutions. Unfortunately, in my opinion, these are not elegant solutions. You need to run for example npm update-resolutions, after each npm i.

In the new version of Postcss-normalizer, they have solved the issue. As I remember, we need to have postcss version 8 for the update. In the update-dep(#500) task, I've updated that, and this problem will be resolved when we merge the update 🙂

jakub300 commented 3 years ago

@edenizk could you create a issue in postcss-normlize asking to backport the fix to v9 https://github.com/csstools/postcss-normalize/pull/60 ?

edenizk commented 3 years ago

@jakub300, I think this is a related issue https://github.com/csstools/postcss-normalize/issues/62

jakub300 commented 3 years ago

Hi all, I created @jakub300/postcss-normalize that should work fine and released new chisel version (generator-chisel@1.0.0-alpha.13)