[Bug] Auto model not working

EpicGamer42069Fortnite commented 1 year ago

Describe the bug

Models do not convert automatically from wide to slim.

Steps to reproduce

1. In the config, have the model option set to "auto".
2. Set your launcher skin to a wide skin.
3. Set your "CustomSkinLoader" skin to a slim skin.
4. The skin doesn't convert to slim skin in-game.

Link to crash-report if applicable

No response

Link to CustomSkinLoader.log if applicable

No response

Link to latest.log if applicable

No response

[Only Forge User] Link to Forge Log if applicable

No response

Mod Version

14.18 - 14.18.3-SNAPSHOT-27

Minecraft Version

1.20.1

Minecraft Launcher Name and Version

Vanilla Launcher

Mod Loader

Fabric

Operating System

Windows

Before submitting a bug report

[X] This bug wasn't already reported (I have searched bug reports on GitHub).
[X] This is a valid bug (I am able to reproduce this on the latest dev build).
[X] This problem is triggered in the latest version of the mod (if not the latest please upgrade the mod first)

xfl03 commented 10 months ago

Skin will not be converted. The model used in game will follow the skin origin model.

8MiYile commented 10 months ago

Skin files are what they are, we don't automatically edit them.

EpicGamer42069Fortnite commented 10 months ago

This is what I'm trying to say:

In older versions of the mod, if I had my Minecraft Launcher model set to wide, and my CustomSkinLoader skin is a slim skin, and the model inside the config file set to auto, my player model would automatically change to slim once I load the game, which is correct.

In newer versions of the mod, my model stays as a wide model, even though I put a slim skin inside the CustomSkinLoader folder.

Sorry for the confusion, let me know if you need me to clarify more.

ZekerZhayard commented 10 months ago

Thanks for your feedback. I rechecked the code. Since Mojang changed some of the code related to skin loading after 23w31a, the module's original code was not working. This will be fixed as soon as possible.

Tartilla-TAIGO commented 9 months ago

This bug is also observed in 1.19.3. Is there a way to fix it, or is it necessary to wait for a fix?

xfl03 / MCCustomSkinLoader