xflouris / libpll

Phylogenetic Likelihood Library
GNU Affero General Public License v3.0
27 stars 6 forks source link

Duplicate const qualifier #102

Closed thayerf closed 8 years ago

thayerf commented 8 years ago

In pll.h :

PLL_EXPORT int pll_core_likelihood_derivatives(unsigned int states,
                                               unsigned int sites,
                                               unsigned int rate_cats,
                                               const double * rate_weights,
                                               const unsigned int * parent_scaler,
                                               const unsigned int * child_scaler,
                                               const int * invariant,
                                               const unsigned int * pattern_weights,
                                               double branch_length,
                                               const double * prop_invar,
                                               double ** freqs,
                                               const const double * rates,
                                               double ** eigenvals,
                                               const double * sumtable,
                                               double * d_f,
                                               double * dd_f,
unsigned int attrib);

rates has a duplicate const qualifier, this compiles in C99, but not C++11. Does this serve a purpose here, or can it be removed? Thanks!

xflouris commented 8 years ago

thanks @thayerf. I'm aware of this, and we'll remove it (along with several other inconsistencies) this week.

ddarriba commented 8 years ago

Thanks Thayerf,

I was already aware of that and it is already fixed locally. It was just a mistake.