xflouris / libpll

Phylogenetic Likelihood Library
GNU Affero General Public License v3.0
26 stars 6 forks source link

newton.c example misinterprets pll_compute_likelihood_derivatives return value #116

Closed bcclaywell closed 4 years ago

bcclaywell commented 7 years ago

The Newton's method branch length optimization example (newton.c) appears to misinterpret what pll_compute_likelihood_derivatives returns here. It stores the return value as double opt_logl (optimized log-likelihood?) when in fact the function returns an int that as far as I can tell is a status code.

xflouris commented 7 years ago

thanks @bcclaywell , we forgot to update the example after a recent change in the derivative functions. I'll update the code beginning of next week.

xflouris commented 7 years ago

started working on this

stamatak commented 6 years ago

can we close this?