search

xflr6 / graphviz

Simple Python interface for Graphviz
https://graphviz.readthedocs.io
MIT License
1.59k stars 209 forks source link

migrate from external mock package to stdlib unittest.mock #212

Closed eli-schwartz closed 7 months ago

eli-schwartz commented 7 months ago

The PyPI standalone mock package is a straight backport of the stdlib to older versions of python. It is usually not needed.

In this case, the required version of mock is >=4, which backports the python 3.8 stdlib. The minimum version of python required is already 3.8, so all functionality guaranteed to exist is already part of the stdlib.

Simply use the stdlib directly.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (448d1a0) 100.00% compared to head (51ecc84) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #212 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 33 33 Lines 1085 1085 ========================================= Hits 1085 1085 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xflr6 commented 7 months ago

Thanks, +1 should not be needed and more.