search

xflr6 / graphviz

Simple Python interface for Graphviz
https://graphviz.readthedocs.io
MIT License
1.59k stars 209 forks source link

Fix call-signature related own `PendingDeprecationWarning` in tests #218

Closed xflr6 closed 1 month ago

xflr6 commented 3 months ago

E.g. in https://github.com/xflr6/graphviz/actions/runs/8317979263

PendingDeprecationWarning: The signature of save will be reduced to 1 positional arg ['filename']:
pass directory='doctest-output/round-table.gv' as keyword arg(s)
    filepath = self.save(filename, directory=directory, skip_existing=None)

Possibly related to e5578d39009469df2b7c6743458970643e228226.

mtelka commented 3 months ago

To suppress warnings it is recommended to test with -W ignore:"The signature of":PendingDeprecationWarning.

kloczek commented 3 months ago

Is it not possible to fix that warning instead calming it down? 🤔 (just asking)

mtelka commented 3 months ago

Sure, it is and I believe it will be fixed by @xflr6 soon.

xflr6 commented 3 months ago

Sorry for the warning noise (my bad), new relase is underway.

xflr6 commented 3 months ago

Fixed in https://pypi.org/project/graphviz/0.20.3/

Gives us some time to work on a proper fix.

xflr6 commented 1 month ago

Should be fixed by f0297099dac4ff3e7769ed5ace95718e53d2a5f7